-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change the encoding into utf-8 #8
Conversation
Update: in the line 250 of parser.py |
Thanks so much for the PR! I'm planning to update BRENDApyrser to accommodate the newly available json format, see issue #9. I'll leave this PR on hold for now since most likely this issue with the references will be solved. |
Thank you for your reply! And I successfully made a database of enzyme kinetics using BRENDApyrser which is very powerful! For me, parsing the json is a good idea, it will save a lot of time in parsing the data, but the change in this commit is needed regardless of whether the data format is .txt or .json since it will impact the consistency of the content in the references. Best regards, |
Glad to hear that! It's awesome to learn that you have found the package useful! |
Hi @MistyField , sorry, could you update your branch with the current master branch to resolve these conflicts prior to merge? |
Hello, I've updated my forked branch with the master branch:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to merge this commit with the ".idea" directory from JetBrains? This is a local directory, shouldn't be in the repo. Please, could you remove it? We don't need to include ".idea" in .gitignore either.
Otherwise, I'm fine with the rest of the PR!
Of course! Apologize for the inconvenience I caused by changing the .gitignore🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Thank you!
No worries ! Merging PR |
No description provided.