Fix FlexAttention cross-attention masks for dynamic text lengths#107
Draft
Arison591 wants to merge 1 commit into
Draft
Fix FlexAttention cross-attention masks for dynamic text lengths#107Arison591 wants to merge 1 commit into
Arison591 wants to merge 1 commit into
Conversation
Signed-off-by: Haoran Qian <haoran@hust.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlexAttnFunc.init_maskRoot cause
During post-training, text embeddings are flattened from
[B, L, C]to[1, B * L, C]before cross-attention. The FlexAttention cross mask was always built forB * 512key/value tokens, so any embedding length other than 512 produced a mask/KV shape mismatch.This keeps the existing per-sample masking semantics while making the mask length match the actual projected text sequence.
Fixes #82.
Validation
B=2,L=20: mask shape(1, 1, 256, 1024)rejected runtimekv_len=40FlexAttnFuncwithB=2,L=20: mask shape(1, 1, 256, 40), BF16 output shape(1, 256, 2, 64), all values finitepython -m py_compile wan_va/modules/model.pygit diff --check