Repository navigation
Validate request path segments and install the release build from the lockfile - #302
Merged
Merged
Conversation
Member
Author
|
Companion PRs for the one release: robosystems RoboFinSystems/robosystems#1945 · robosystems-core RoboFinSystems/robosystems-core#98 · robosystems-typescript-client #302 · robosystems-python-client RoboFinSystems/robosystems-python-client#286 · robosystems-app RoboFinSystems/robosystems-app#518 · roboledger-app RoboFinSystems/roboledger-app#527 |
This was referenced Oct 25, 2026
Merged
Merged
The release job installs with npm ci; CI does the same, so a lockfile out of step with package.json fails on the pull request rather than at publish.
jfrench9
added a commit
that referenced
this pull request
Oct 25, 2026
Doc-only follow-up to #302: the `LedgerEventHandler` and `updateEventHandler` comments now say that approving an AI-suggested handler sends `expected_updated_at` (the `updatedAt` the person reviewed) and that the API answers 409 if the handler changed since. No code change; rides the next minor. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardening from a platform security review; companion to the robosystems
bugfix/input-validation-hardeningPR. Public text is deliberately brief.createGraphQLClientandSSEClientvalidate the value interpolated into a request path as a single segment and encode itbrowser_nonce_hash,browser_nonce,expected_updated_at) — additive, generated tiernpm ci --ignore-scriptsClient contract
Additive: a client minor.
createGraphQLClientnow throws on agraphIdthat is not a single path segment — ids as the API issues them are unaffected.Test plan
npm run test— 495 passed (newclients/pathSegment.test.ts)npm run typecheck,npm run lint🤖 Generated with Claude Code