Skip to content

Conversation

@Spir0u
Copy link

@Spir0u Spir0u commented Nov 25, 2025

Public API Changes
Actions forward an error when not available/they get cancelled

Description

  1. When no server is available, I raise an Eexception to get feedback.
  2. throwing an exception in goal_response_cb does not work properly, therefore I return it in the self.result. Probably there would be a better option, but this was working for me.
  3. The result was still none when the action was cancelled, so I put the empty result directly in the return of execute_callback.

The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in  send_goal
@bjsowa bjsowa self-requested a review November 28, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant