fix(params): prevent parameter retrieval crashes in ROS2 #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add check for node's fully qualified name to prevent deadlocks - Add 2.0s timeout to spin_until_future_complete - Fix crashes when retrieving parameters via Roslibjs Fixes RobotWebTools#972
sea-bass
reviewed
Jan 4, 2025
Mehsias
force-pushed
the
fix/issue-972-parameter-retrieval
branch
from
237d668 to
fbed931
Compare
|
@sea-bass I don't know what I did to break the whole CI. I force pushed a squashed commit because the linter check was failing, and now everything is failing. |
|
You somehow broke the |
bjsowa
requested changes
Jan 19, 2025
bjsowa
approved these changes
Jan 25, 2025
bjsowa
added a commit
that referenced
this pull request
Jan 25, 2025
* fix(params): prevent parameter retrieval crashes in ROS2 - Add check for node's fully qualified name to prevent deadlocks - Add 2.0s timeout to spin_until_future_complete - Fix crashes when retrieving parameters via Roslibjs Fixes #972 * added parameter for timeout * Add new service to retrieve the different interfaces in the ROS Network (#988) * Fix rosbridge_websocket symlink * Don't fail on nodes without parameter services * Remove added empty line --------- Co-authored-by: Błażej Sowa <[email protected]> Co-authored-by: Matthias Rathauscher (LWN) <[email protected]> Co-authored-by: Lebecque Florian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Fixes #972