Skip to content

Conversation

@gonzalocasas
Copy link
Collaborator

@gonzalocasas gonzalocasas commented Oct 6, 2025

Before releasing 2.0, I wanted to clean up, and move some stuff around regarding the ROS2 action support:

  • Added wait_goal to wait for an action goal
  • Moved actionlib inside roslibpy.ros1 to avoid confusion with having to identically named things in roslibpy and roslibpy.actionlib, so, now usage of ROS1's actionlib is explicit. This is a breaking change.
  • Added integration tests for the ROS2 action client
  • For ROS2, updated integration launch files to use python instead of XML format.
  • PR Fix KeyError in ROS2 ActionClient when receiving action results from rosbridge #142 is also merged into this, so, ideally we review/merge that one first

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@gonzalocasas
Copy link
Collaborator Author

@sea-bass @EzraBrooks could you also take a look at this one, pls? thx!

Copy link

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As a nitpick, there are many comments throughout this PR that say "ROS2" instead of the preferred styling "ROS 2" with the space. If you'd like to update those, that would be appreciated.

Args:
request (:class:`.ServiceRequest`): Service request.
Args:
goal (:class:`.ActionGoal`): Action goal.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just .Goal in ROS 2

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise it's just .Request and .Response for services

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the action-related classes to remove the Action prefix at 7c52a8d
For now, if you agree, I would prefer to keep ServiceRequest and ServiceResponse names as they are to minimize the breaking changes.

If that's ok, then I will merge this PR

@gonzalocasas
Copy link
Collaborator Author

LGTM!

As a nitpick, there are many comments throughout this PR that say "ROS2" instead of the preferred styling "ROS 2" with the space. If you'd like to update those, that would be appreciated.

styling fixed at 2c1ee67

@gonzalocasas gonzalocasas requested a review from sea-bass October 7, 2025 12:41
@gonzalocasas
Copy link
Collaborator Author

@sea-bass thanks!! merging!

@gonzalocasas gonzalocasas merged commit e54af07 into main Oct 7, 2025
9 checks passed
@gonzalocasas gonzalocasas deleted the updates-ros2-support branch October 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants