chore: rai-perception - update docs to use pip install and add more tests #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juliaj
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 78 78
Lines 3386 3386
=======================================
Hits 2212 2212
Misses 1174 1174 ☔ View full report in Codecov by Sentry. |
5 tasks
maciejmajek
reviewed
Nov 28, 2025
Comment on lines
+46
to
+50
| # TODO(juliaj): Investigate why timestamp is sometimes rclpy.time.Time and sometimes | ||
| # builtin_interfaces.msg.Time. The function signature expects rclpy.time.Time, but | ||
| # grounding_dino.py calls .to_msg() before passing it. Should we fix the caller or | ||
| # change the signature to accept Union[rclpy.time.Time, builtin_interfaces.msg.Time]? | ||
| # Handle both rclpy.time.Time (call to_msg()) and builtin_interfaces.msg.Time (use directly) |
Member
There was a problem hiding this comment.
Weird. I will invastigate
maciejmajek
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support #697
Proposed Changes
rai-perceptionREADME to install package via pipTesting