Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RJD-1336/fix_request_speed_change_throws #42

Merged
merged 99 commits into from
Nov 7, 2024

Conversation

robomic
Copy link

@robomic robomic commented Oct 1, 2024

Abstract

Please refer to this issue.

Details

  1. Inversion of order in if statements

if (!continuous && isTargetSpeedReached(target_speed)) --->
if (isTargetSpeedReached(target_speed) && !continuous)
this forces calculation of relative_target_speed, which throws immediately, if invalid.
3. Numerous const qualifiers added.

References

issue
jira ticket

shouth and others added 30 commits August 20, 2024 17:24
f0reachARR and others added 28 commits October 10, 2024 13:14
Reducing build time of `openscenario_interpreter` by utilizing precompiled headers
fix(cpp_mock_scenarios, ego_entity_simulation): fix ego issue in random001, fix getCurrentPose()
Signed-off-by: Masaya Kataoka <[email protected]>
…nts2

Added checks for negative discriminants
…scenario_simulator_v2 into RJD-1336/fix_request_speed_change
@github-actions github-actions bot deleted the RJD-1336/fix_request_speed_change branch November 7, 2024 06:38
@robomic robomic merged commit 7999c9e into RobotecAI:master Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.