forked from tier4/scenario_simulator_v2
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RJD-1336/fix_request_speed_change_throws #42
Merged
robomic
merged 99 commits into
RobotecAI:master
from
tier4:RJD-1336/fix_request_speed_change
Nov 7, 2024
Merged
RJD-1336/fix_request_speed_change_throws #42
robomic
merged 99 commits into
RobotecAI:master
from
tier4:RJD-1336/fix_request_speed_change
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing build time of `openscenario_interpreter` by utilizing precompiled headers
fix(cpp_mock_scenarios, ego_entity_simulation): fix ego issue in random001, fix getCurrentPose()
Signed-off-by: Masaya Kataoka <[email protected]>
…is not efficient" Signed-off-by: Masaya Kataoka <[email protected]>
…nts2 Added checks for negative discriminants
…scenario_simulator_v2 into RJD-1336/fix_request_speed_change
Fix/remove warnings from sonarcloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Please refer to this issue.
Details
if (!continuous && isTargetSpeedReached(target_speed))
--->if (isTargetSpeedReached(target_speed) && !continuous)
this forces calculation of relative_target_speed, which throws immediately, if invalid.
3. Numerous
const
qualifiers added.References
issue
jira ticket