Elasticsearch update #249
Merged
Elasticsearch update #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports configurable authentication for Elasticsearch.
Updates indexers to check need for api_key
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
|
@helrond Would you mind taking a look at this PR? I'm not sure why it's failing. |
helrond
requested changes
Jan 15, 2025
I think those are KeyErrors - take a look at the changes I've proposed above and see if that first one addresses the failed test. |
fix settings check in indexer Co-authored-by: Hillel Arnold <[email protected]>
p-galligan
temporarily deployed
to
development
GitHub Actions
Inactive
Changes the configs, indexer, and settings to simplify checking for an API key.
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
Remove the version number, which is no longer supported.
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
p-galligan
had a problem deploying
to
development
GitHub Actions
Failure
Fixes configuration of the API key and updates settings variable check
p-galligan
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates application to allow configurable API authentication with Elasticsearch