feat: Upgrade to React Native 0.72.3 #5128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo 49 (only main), reanimated 3, fab removed, RN patch removed, RN path manually set on podfile
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
f8fb24a to
71dafd3
Compare
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
942bab4 to
72fa2ea
Compare
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
44189f4 to
c5726db
Compare
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
c5726db to
1d99145
Compare
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
2c4c881 to
43a131f
Compare
diegolmello
force-pushed
the
chore.upgrade-rn72
branch
from
ce3dae4 to
60a8108
Compare
diegolmello
commented
Jul 17, 2023
| - restore_cache: *restore-gradle-cache | ||
|
|
||
| - save_cache: *save-npm-cache-linux | ||
| # - restore_cache: *restore-gradle-cache |
Member
Author
There was a problem hiding this comment.
Had to do it to build properly.
Removed here only, because e2e tests seems to work with it.
Probably because here it's bundling, while there it's assembling.
After we get rid of the RN Android fork, we might be able to enable it again.
diegolmello
changed the title
dnlsilva
suggested changes
Jul 17, 2023
Contributor
dnlsilva
left a comment
dnlsilva
left a comment
There was a problem hiding this comment.
did checkout on branch .
deleted the node_modules folder and yarn again.
pod install (Here there was an error, but running pod update worked)
When clicking on the emoji in any conversation, this error appears:
Co-authored-by: Gleidson Daniel Silva <[email protected]>
Co-authored-by: Gleidson Daniel Silva <[email protected]>
dnlsilva
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Depends on RocketChat/rn-extensions-share#10
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
NATIVE-368