-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: text Input Field Not Visible on First time direct message #6214
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you write unit tests for this?
Apologies, didnt see this message earlier, sure, on it! |
Hey @diegolmello , added some tests for the hook, please let me know if there is an edge case i have missed. Thanks! |
Hey @diegolmello, I’ve moved the tests into a single file for better modularity. Let me know if I missed anything or if there’s anything that could be improved. Thanks! |
Proposed changes
This PR resolves an issue where the text input field is not visible when initiating a direct message with a user for the first time in the app. The problem stemmed from improper rendering of the text input field, which was caused by the useSubscription hook not functioning correctly. As a result, the placeholder was not being set, leading to errors and ultimately preventing the text input field from being displayed.
Issue(s)
#6211
How to test or reproduce
Screenshots
VID_20250308_111854.mp4
Types of changes
Checklist