-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: convert Message Touchable to React Native Gesture Handler #6218
Open
jjinendra3
wants to merge
8
commits into
RocketChat:develop
Choose a base branch
from
jjinendra3:enhance/switchToRNGH
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+278
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's promising!
- Animation should look more like this https://telegram.tips/blog/swipe-left-to-reply/
- Missing haptic feedback when the threshold is reached
Added Haptics to press as well as PanGesture. Switched to GestureDetector and redesigned the thread swipe gesture. If there are any discrepancies or if any refactor is needed, please do comment it. Screenrecorder-2025-03-11-17-45-20-688.mp4 |
diegolmello
requested changes
Mar 14, 2025
…Rocket.Chat.ReactNative into enhance/switchToRNGH
…eactNative into enhance/switchToRNGH
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Converted the message touchable to use React Native Gesture Handler (RNGH) instead of the default touchable.
Added left swipe to open thread functionality.
Benefits of switching to RNGH:
Issue(s)
#6193
How to test or reproduce
Screenshots
Screenrecorder-2025-03-10-22-22-53-840.mp4
Types of changes
Checklist
Further comments