-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: convert Message Touchable to React Native Gesture Handler #6218
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's promising!
- Animation should look more like this https://telegram.tips/blog/swipe-left-to-reply/
- Missing haptic feedback when the threshold is reached
Added Haptics to press as well as PanGesture. Switched to GestureDetector and redesigned the thread swipe gesture. If there are any discrepancies or if any refactor is needed, please do comment it. Screenrecorder-2025-03-11-17-45-20-688.mp4 |
app/containers/message/Toucher.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep Touchable.
app/containers/message/styles.ts
Outdated
actionButton: { | ||
width: 28, | ||
height: 28, | ||
backgroundColor: 'rgba(0, 0, 0, 0.15)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use themes
…Rocket.Chat.ReactNative into enhance/switchToRNGH
…eactNative into enhance/switchToRNGH
Proposed changes
Converted the message touchable to use React Native Gesture Handler (RNGH) instead of the default touchable.
Added left swipe to open thread functionality.
Benefits of switching to RNGH:
Issue(s)
#6193
How to test or reproduce
Screenshots
Screenrecorder-2025-03-10-22-22-53-840.mp4
Types of changes
Checklist
Further comments