chore: Add missing error state to ModerationConsoleTable#38969
chore: Add missing error state to ModerationConsoleTable#38969smirk-dev wants to merge 2 commits into
ModerationConsoleTable#38969Conversation
Add error handling UI when the moderation reports query fails: - Display warning icon with 'Something went wrong' message - Add 'Reload page' button that triggers refetch Resolves TODO comment in the component.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThe ModerationConsoleTable component now includes error state handling. Query return values were extended to include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38969 +/- ##
===========================================
- Coverage 70.93% 69.84% -1.10%
===========================================
Files 3209 3298 +89
Lines 113886 119292 +5406
Branches 20646 21937 +1291
===========================================
+ Hits 80788 83321 +2533
- Misses 31048 32671 +1623
- Partials 2050 3300 +1250
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hi RocketChat team, just a gentle ping — this PR has been open for about 3 weeks. Would someone be able to take a look when time allows? Happy to address any feedback. Thanks! |
|
Hello @smirk-dev and thank you so much for your contribution 🚀 My honest apologies, but we're receiving tons of contributions and our team just can't handle all of them. I can understand how frustrating can be do not receive any feedback, so I hope you can understand our situation and keep helping us. |
|
/jira COMM |
ModerationConsoleTable
|
@dougfabris so are you merging it or is just added to milestone, did you add this to the queue |
|
@smirk-dev its a valid contribution and its on our radar. |
|
@dougfabris status? |
|
@smirk-dev Your PR is triaged so it will be included in our next release. For now just sit down, relax and enjoy the trip |
|
@dougfabris its been 3 months since this pr was opened, can i get a timeline of whether or when it will be merged? |
Summary
Add error state handling to the ModerationConsoleTable component when the API query fails.
Changes
@rocket.chat/fuselageisErrorandrefetchfrom the useQuery hookBefore
The component only handled loading and success states. If the API request failed, users would see nothing (no feedback).
After
Users see a clear error message with "Something went wrong" and a "Reload page" button to retry.
Resolves the TODO comment that was in the component.
Summary by CodeRabbit
Task: COMM-160