Skip to content

fix: preserve aspect ratio for URL image previews #40399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TasfinMahmud wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −2
Open

fix: preserve aspect ratio for URL image previews #40399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-url-image-aspect-ratio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixed incorrect aspect ratios for URL image previews (e.g., Giphy GIFs) by adding `object-fit: contain` and `width: auto` to the `UrlImagePreview` component, ensuring images scale proportionally within the max-height constraint.
10 changes: 8 additions & 2 deletions apps/meteor/client/components/message/content/urlPreviews/UrlImagePreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,14 @@ const UrlImagePreview = ({ url }: Pick<UrlPreviewMetadata, 'url'>): ReactElement
const { maxHeight: oembedMaxHeight } = useOembedLayout();

return (
<Box maxHeight={oembedMaxHeight} maxWidth='100%'>
<MessageGenericPreviewImage data-id={url} className='preview-image' url={url || ''} alt='' />
<Box maxHeight={oembedMaxHeight} maxWidth='100%' overflow='hidden'>
<MessageGenericPreviewImage
data-id={url}
className='preview-image'
url={url || ''}
alt=''
style={{ maxHeight: oembedMaxHeight, width: 'auto', maxWidth: '100%', objectFit: 'contain' }}
/>
</Box>
);
};
Expand Down