chore: Modernize codebase to node 22#40535
Merged
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
Important Review skippedToo many files! This PR contains 158 files, which is 8 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (158)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
tassoevan
requested changes
May 15, 2026
tassoevan
requested changes
May 15, 2026
tassoevan
requested changes
May 15, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #40535 +/- ##
===========================================
- Coverage 69.74% 69.66% -0.08%
===========================================
Files 3322 3322
Lines 122773 122775 +2
Branches 21870 21896 +26
===========================================
- Hits 85623 85533 -90
- Misses 33807 33885 +78
- Partials 3343 3357 +14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
force-pushed
the
chore/node22-modernization
branch
from
ae42aba to
88c3f4c
Compare
tassoevan
force-pushed
the
chore/node22-modernization
branch
from
88c3f4c to
faef962
Compare
Unlocks Node 22 built-ins (Object.hasOwn, toSorted, findLast, etc.). Target kept at es2020 to preserve class-field semantics.
- authorization.getRoles: `.sort` → `.toSorted` (no in-place mutation)
- SignalProcessor.reactToUnknownCall: `Promise.all + .catch(()=>null)` → `Promise.allSettled`
- EmojiCustom.findByNameOrAlias / OmnichannelTranscript: literal-pattern `.replace(/x/g, ...)` → `.replaceAll('x', ...)`
6 server-side call sites drop the uuid lib in favor of Node's built-in
randomUUID(). Federation Settings also collapses the new RegExp('-','g')
into .replaceAll('-', '_').
Sweep across server-side packages: prefix `fs`, `path`, `crypto`, `stream`, `http`, `util`, `events` and other Node builtins with the `node:` protocol. Skipped client widget code under `packages/livechat/src/` and compiled apps-engine output.
tassoevan
force-pushed
the
chore/node22-modernization
branch
from
faef962 to
04865bf
Compare
Member
Author
|
/jira CORE |
tassoevan
approved these changes
May 19, 2026
tassoevan
added
the
stat: QA assured
dionisio-bot
Bot
added
the
stat: ready to merge
ricardogarim
approved these changes
May 19, 2026
aleksandernsilva
approved these changes
May 19, 2026
sampaiodiego
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
⏺ Adopt Node 22 / modern ES built-ins across server code
The shared @rocket.chat/tsconfig/server.json was pinned to lib: ["es2020"], even though every server package runs on Node 22. That mismatch hid ES2022/2023 APIs from
TypeScript and forced older idioms. Bumping only lib (target stays at es2020 to preserve class-field semantics) is a strict superset — no emitted JS changes — and is
the prerequisite for the rest of the commits.
ES2022's Object.hasOwn(obj, key) is the standardized replacement for obj.hasOwnProperty(key). It avoids the prototype-pollution / shadowing footgun and works on
null-prototype objects (Object.create(null)) without the ugly Object.prototype.hasOwnProperty.call(...) workaround. Mechanical swap, identical semantics.
Six call sites used the uuid package solely to mint a random v4 UUID. Node has provided crypto.randomUUID() since 14.17 with identical RFC 4122 output and a more
specific return type. The federation Settings.ts site also collapses an old replace(new RegExp('-', 'g'), '') into .replaceAll('-', '').
Sweep across 151 server-side files: from 'fs' → from 'node:fs', etc. Two motivations:
short-circuits resolution and refuses to find an imposter.
Issue(s)
Steps to test or reproduce
Further comments
Task: CORE-2204