Skip to content

fix(custom-oauth): pass SSRF allowlist to all fetch calls in CustomOAuth #40587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Varun789-mx wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(custom-oauth): pass SSRF allowlist to all fetch calls in CustomOAuth #40587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions apps/meteor/app/custom-oauth/server/custom_oauth_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ export class CustomOAuth {

try {
const request = await fetch(`${this.tokenPath}`, {
// SECURITY: URL can only be configured by users with enough privileges. It's ok to disable this check here.
ignoreSsrfValidation: true,
// SECURITY: URL can only be configured by privileged admins. Enforcing SSRF allowlist instead of full bypass.
method: 'POST',
headers,
body: params,
allowList: settings.get('SSRF_Allowlist')
Comment thread
coderabbitai[bot] marked this conversation as resolved.
});

if (!request.ok) {
Expand Down Expand Up @@ -181,8 +181,8 @@ export class CustomOAuth {
}

try {
// SECURITY: URL can only be configured by users with enough privileges. It's ok to disable this check here.
const request = await fetch(`${this.identityPath}`, { method: 'GET', headers, params, ignoreSsrfValidation: true });
// SECURITY: URL can only be configured by privileged admins. Enforcing SSRF allowlist instead of full bypass.
const request = await fetch(`${this.identityPath}`, { method: 'GET', headers, params, allowList: settings.get('SSRF_Allowlist') });

if (!request.ok) {
throw new Error(request.statusText);
Expand Down Expand Up @@ -288,9 +288,8 @@ export class CustomOAuth {
}

try {
// SECURITY: URL can only be configured by users with enough privileges. It's ok to disable this check here.
const request = await fetch(`${this.emailPath}`, { method: 'GET', headers, params, ignoreSsrfValidation: true });

// SECURITY: URL can only be configured by privileged admins. Enforcing SSRF allowlist instead of full bypass.
const request = await fetch(`${this.emailPath}`, { method: 'GET', headers, params, allowList: settings.get('SSRF_Allowlist') });
if (!request.ok) {
throw new Error(request.statusText);
}
Expand Down