Skip to content

fix(apps): resolve deno-runtime module not found after upgrade#40947

Open
dsaicharan072-cmyk wants to merge 2 commits into
RocketChat:developfrom
dsaicharan072-cmyk:fix/deno-runtime-symlink-upgrade
Open

fix(apps): resolve deno-runtime module not found after upgrade#40947
dsaicharan072-cmyk wants to merge 2 commits into
RocketChat:developfrom
dsaicharan072-cmyk:fix/deno-runtime-symlink-upgrade

Conversation

@dsaicharan072-cmyk

@dsaicharan072-cmyk dsaicharan072-cmyk commented Jun 14, 2026

Copy link
Copy Markdown

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of Deno runtime initialization by making the temporary runtime symlink setup idempotent and self-healing, automatically recreating broken or stale symlinks during server startup.

@dionisio-bot

dionisio-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Jun 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 805421d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/apps Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant

CLAassistant commented Jun 14, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f083ce4c-186e-41a5-86e2-2a32c7183bad

📥 Commits

Reviewing files that changed from the base of the PR and between 1f785da and 805421d.

📒 Files selected for processing (2)
  • .changeset/fix-deno-runtime-symlink.md
  • packages/apps/src/server/runtime/deno/AppsEngineDenoRuntime.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/fix-deno-runtime-symlink.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/apps/src/server/runtime/deno/AppsEngineDenoRuntime.ts

Walkthrough

The Deno runtime constructor's symlink setup is changed from a one-shot symlinkSync (ignoring EEXIST) to a conditional flow that reads the existing symlink, compares it to the expected target, checks for broken links, and only removes and recreates the symlink when it is missing, mismatched, or broken. A patch release changeset documents this fix.

Changes

Deno Runtime Symlink Fix

Layer / File(s) Summary
Idempotent symlink creation and release tracking
packages/apps/src/server/runtime/deno/AppsEngineDenoRuntime.ts, .changeset/fix-deno-runtime-symlink.md
Symlink setup now computes the expected source/target, reads any existing symlink with readlinkSync, validates it against the expected target and checks for broken state, then removes and recreates only when necessary. The fix is documented in a patch release changeset for @rocket.chat/apps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(apps): resolve deno-runtime module not found after upgrade' clearly and specifically describes the main change - fixing a deno-runtime module resolution issue that occurs after an upgrade.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@dsaicharan072-cmyk dsaicharan072-cmyk force-pushed the fix/deno-runtime-symlink-upgrade branch from f7dd0e3 to 1f785da Compare June 14, 2026 17:44
@coderabbitai coderabbitai Bot removed the type: bug label Jun 14, 2026
@dsaicharan072-cmyk dsaicharan072-cmyk force-pushed the fix/deno-runtime-symlink-upgrade branch from 1f785da to 805421d Compare June 14, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants