Improve api granularity

[GabrielBarberini]

Summary by CodeRabbit

• Refactor
  • Improved parameter handling robustness to prevent potential conflicts during configuration processing.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The change modifies src/services/rocket.py to introduce selective parameter forwarding via extra_kwargs. This new dictionary filters additional fin parameters to exclude those already present in base_kwargs, preventing key collisions when constructing RocketPy fins objects. The modification refines parameter handling without altering error handling or control flow.

Changes

Cohort / File(s)	Summary
Fin parameter collision prevention src/services/rocket.py	Introduces extra_kwargs to selectively forward additional fin parameters not already defined in base_kwargs, replacing the previous approach of passing all fins.get_additional_parameters() to prevent key collisions

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Key areas requiring attention:
  • Verify the filtering logic correctly identifies and excludes parameters already in base_kwargs
  • Confirm that no required fin parameters are inadvertently filtered out
  • Validate that the RocketPy fins object receives all necessary parameters after the change
  • Check edge cases where fins.get_additional_parameters() might return empty or unexpected structures

Poem

🐰 A collision was found, oh what a fright!
Extra kwargs stepped in to set things right.
Filter by filter, no doubles today,
Parameters flow the cleaner way! 🚀

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch improve-api-granularity

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ed5aa4 and ebd7cf7.

📒 Files selected for processing (1)

• src/services/rocket.py (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}