Skip to content

Commit

Permalink
MNT: applying suggested review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Lucas-Prates authored and Gui-FernandesBR committed Sep 14, 2024
1 parent f7b4b03 commit 7f29049
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
5 changes: 0 additions & 5 deletions rocketpy/rocket/aero_surface/fins/fins.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,11 +378,6 @@ def compute_forces_and_moments(
): # pylint: disable=arguments-differ
"""Computes the forces and moments acting on the aerodynamic surface.
Parameters
----------
stream_speed : int, float
Speed of the flow stream in the body frame.
"""
R1, R2, R3, M1, M2, _ = super().compute_forces_and_moments(
stream_velocity,
Expand Down
16 changes: 8 additions & 8 deletions rocketpy/rocket/aero_surface/generic_surface.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,12 @@ def _check_coefficients(self, input_coefficients, default_coefficients):
ValueError
Raises a value error if the input coefficient has an invalid key
"""
for key in input_coefficients.keys():
if key not in default_coefficients.keys():
raise ValueError(
"Invalid coefficient name used in key! Check the "
+ "documentation for valid names."
)
invalid_keys = set(input_coefficients) - set(default_coefficients)
if invalid_keys:
raise ValueError(
f"Invalid coefficient name(s) used in key(s): {', '.join(invalid_keys)}. "
"Check the documentation for valid names."
)

def _compute_from_coefficients(
self,
Expand Down Expand Up @@ -256,10 +256,10 @@ def compute_forces_and_moments(
Air density.
cp : Vector
Center of pressure coordinates in the body frame.
omega: tuple[float, float, float]
Tuple containing angular velocities around the x, y, z axes.
reynolds : float
Reynolds number.
omega: tuple of float
Tuple containing angular velocities around the x, y, z axes.
Returns
-------
Expand Down

0 comments on commit 7f29049

Please sign in to comment.