Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add juno3 flight example #513

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

A new flight was added to the Flight Examples section on our documentation.

Breaking change

  • No

Additional information

image

@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label Dec 17, 2023
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Dec 17, 2023
@Gui-FernandesBR Gui-FernandesBR self-assigned this Dec 17, 2023
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner December 17, 2023 07:07
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting here so I don't forget: this file weights more than 20MB, I still need to compress the .nc file so we can save cloud space.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I didn't compress this time, but we can compress later and clean the git history.

http://climate-cms.wikis.unsw.edu.au/NetCDF_Compression_Tools

Base automatically changed from enh/compare-flight-data to develop December 18, 2023 03:48
@Gui-FernandesBR
Copy link
Member Author

@MateusStano we need an "approve" to move along and merge this one.

@Gui-FernandesBR Gui-FernandesBR merged commit 6347371 into develop Dec 18, 2023
4 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/add-juno3-example branch December 18, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants