Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix Orientation Param of Inertial Sensors #688

Merged
merged 5 commits into from
Sep 14, 2024

Conversation

MateusStano
Copy link
Member

Descriptiom

Small change to orientation param of the InertialSensor class due to changes in the rocket axes definitions from #635

The rotation has been changed from 3-2-1 to 3-1-3 for ease of use

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once the tests get concluded.

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (186cae7) to head (18a99a7).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #688      +/-   ##
===========================================
- Coverage    75.42%   75.40%   -0.03%     
===========================================
  Files           96       96              
  Lines        10841    10832       -9     
===========================================
- Hits          8177     8168       -9     
  Misses        2664     2664              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit dca3a84 into develop Sep 14, 2024
7 of 8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/fix-orientation-sensors branch September 14, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants