Merged
Conversation
Rogdham
force-pushed
the
zstd-v1.5.7
branch
2 times, most recently
from
f952cf9 to
b037cfd
Compare
Rogdham
commented
Feb 26, 2025
setup.py
Outdated
|
|
||
| for extension in self.extensions: | ||
| if self.compiler.compiler_type in ('unix', 'mingw32', 'cygwin'): | ||
| # Remove -Wunreachable-code default args based on how Python was build |
Owner
Author
There was a problem hiding this comment.
If anyone has a better idea how to do this, feel free to chime in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/facebook/zstd/releases/tag/v1.5.7