fix(qdrant): resolve URL port handling bug for HTTPS URLs

[benashby]

Related GitHub Issue

Closes: #4991

Description

Fixed QdrantVectorStore URL parsing logic that incorrectly appended :6333 to HTTPS URLs.

Key implementation changes:

• Added parseQdrantUrl() method with protocol-aware port handling
• HTTPS URLs without explicit ports now preserve default behavior (port 443)
• HTTP URLs without explicit ports correctly get :6333 appended
• Added parseHostname() helper for hostname-only inputs
• Maintains backward compatibility for all existing URL formats

Design choice: Used JavaScript's built-in URL constructor for robust parsing with fallback to hostname detection for malformed inputs.

Test Procedure

Unit Tests: 46 comprehensive tests covering all URL formats:

cd src/services/code-index/vector-store && npm test -- __tests__/qdrant-client.spec.ts

Manual Testing:

1. Initialize QdrantVectorStore with 'https://qdrant.example.com'
2. Verify internal URL remains 'https://qdrant.example.com' (not 'https://qdrant.example.com:6333')
3. Test HTTP URLs still get :6333 appended correctly

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (QdrantVectorStore incorrectly appends :6333 port to HTTPS URLs #4991).
• Scope: Changes focused solely on URL parsing bug fix.
• Self-Review: Performed thorough code review.
• Testing: Added comprehensive test coverage (46 test cases).
• Documentation Impact: No user-facing documentation updates required.
• Contribution Guidelines: Read and followed guidelines.

Documentation Updates

• No documentation updates are required.

Additional Notes

All tests pass, ESLint clean. Fix is backward compatible and handles edge cases including IP addresses, custom ports, and malformed URLs.

---

Important

Fixes URL parsing in QdrantVectorStore to correctly handle HTTPS URLs without appending default port :6333.

• Behavior:
  • Fixes URL parsing in QdrantVectorStore to prevent appending :6333 to HTTPS URLs without explicit ports.
  • Adds parseQdrantUrl() in qdrant-client.ts for protocol-aware port handling.
  • HTTP URLs without explicit ports get :6333 appended; HTTPS URLs default to port 443.
  • Adds parseHostname() for hostname-only inputs.
• Testing:
  • 46 unit tests in qdrant-client.spec.ts for various URL formats and edge cases.
  • Tests include handling of IP addresses, custom ports, and malformed URLs.
• Misc:
  • Uses JavaScript's URL constructor for robust parsing with fallback for malformed inputs.

^{This description was created by for fee98ec. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Hardcoded default port (6333) is used in multiple places. Consider defining this as a constant for better maintainability.

[mrubens]

LGTM if @daniel-lxs agrees!

[benashby]

Sorry I made a few more changes. Should be good now.

[CW-B-W]

Hello @benashby,

Would you also use parameter prefix for QdrantClient?

I use Nginx as reverse proxy to connect my Qdrant service, the url used was like https://my-domain/qdrant/.
This setting shall not work without the prefix parameter, as I tried.

(Also QdrantClient doesn't properly set the prefix when parsing url.
ref: qdrant/qdrant-js#104)

Would you refer to my version of fix main...CW-B-W:Roo-Code:fix_qdrant_connection .
I have tried it, it worked for my case.

Thanks!

[daniel-lxs]

Looks good!

Thank you @benashby!