feat: add toggle button to show/hide thinking output #8210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
- Added collapsible state to ReasoningBlock component - Implemented ChevronDown/ChevronUp icons for visual feedback - Made thinking content toggleable with click interaction - Maintains timer display while collapsed Fixes #8209
dosubot
bot
added
size:S
2 tasks
|
|
||
| const startTimeRef = useRef<number>(Date.now()) | ||
| const [elapsed, setElapsed] = useState<number>(0) | ||
| const [isCollapsed, setIsCollapsed] = useState<boolean>(false) |
There was a problem hiding this comment.
Critical Issue: The initial state is false, which means thinking content is shown by default. According to issue #8209, 'Thinking not being hidden by default is a huge pollution to the chat interface'. This should be:
const [isCollapsed, setIsCollapsed] = useState<boolean>(true)This ensures the thinking content starts collapsed as requested.
| <div className="flex items-center gap-2"> | ||
| <div | ||
| className="flex items-center gap-2 cursor-pointer select-none hover:opacity-80" | ||
| onClick={handleToggle}> |
There was a problem hiding this comment.
Accessibility: Missing ARIA attributes for screen reader users. Consider adding aria-expanded and aria-label attributes, plus keyboard support with role='button' and tabIndex={0}.
| const seconds = Math.floor(elapsed / 1000) | ||
| const secondsLabel = t("chat:reasoning.seconds", { count: seconds }) | ||
|
|
||
| const handleToggle = (e: React.MouseEvent) => { |
There was a problem hiding this comment.
UX Improvement: Consider persisting the collapsed state preference using localStorage or VSCode's workspace state so users don't have to collapse it every time.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses Issue #8209 by adding a toggle button to show/hide thinking output in the chat interface, reducing visual pollution when there's extensive thinking content.
Changes
Implementation Details
The solution adds a simple toggle mechanism to the ReasoningBlock component:
Testing
Screenshots
The implementation provides a clean toggle interface similar to what was previously available, with clear visual indicators for the collapsed/expanded state.
Future Improvements
Consider for future iterations:
Fixes #8209
Important
Adds a toggle button to
ReasoningBlockto show/hide thinking output with Chevron icons and maintains timer visibility.ReasoningBlockto show/hide thinking output.ChevronDown/ChevronUpicons.isCollapsedstate inReasoningBlock.handleTogglefunction togglesisCollapsedstate.isCollapsedstate.This description was created by
for 28a6621. You can customize this summary. It will automatically update as commits are pushed.