Skip to content

Conversation

roomote[bot]
Copy link

@roomote roomote bot commented Oct 13, 2025

This PR addresses Issue #8634 by ensuring MCP settings changes are broadcast to all open tabs.

Problem

When MCP tool permissions or server settings are changed from a second Roo tab, the changes were not persisting and appeared to be applied to the original tab instead.

Solution

Modified McpHub.notifyWebviewOfServerChanges() to use McpServerManager.notifyProviders() instead of notifying only the current provider. This ensures all open tabs receive updates when MCP settings change.

Changes

  • Updated src/services/mcp/McpHub.ts to broadcast changes to all providers
  • Updated tests in src/services/mcp/__tests__/McpHub.spec.ts to mock McpServerManager

Testing

  • All existing unit tests pass
  • Manual multi-tab testing cannot be performed in the container environment

Note

This fix addresses the notification aspect of the issue. I have posted questions to the issue for clarification on whether additional changes are needed for:

  • File write operations and persistence
  • Race condition handling with concurrent writes
  • Multi-tab integration testing

Fixes #8634


Important

Broadcast MCP settings changes to all open tabs using McpServerManager.notifyProviders() in McpHub.

  • Behavior:
    • McpHub.notifyWebviewOfServerChanges() now uses McpServerManager.notifyProviders() to broadcast MCP settings changes to all open tabs.
    • Ensures all tabs receive updates when MCP settings change.
  • Testing:
    • Updated tests in McpHub.spec.ts to mock McpServerManager and verify broadcasting behavior.
    • All existing unit tests pass.
  • Misc:
    • Manual multi-tab testing not possible in container environment.

This description was created by Ellipsis for afc8e07. You can customize this summary. It will automatically update as commits are pushed.

- Modified McpHub.notifyWebviewOfServerChanges() to use McpServerManager.notifyProviders()
- This ensures all open tabs receive updates when MCP settings change
- Updated tests to mock McpServerManager instead of direct provider calls
- Fixes #8634
@roomote roomote bot requested a review from mrubens as a code owner October 13, 2025 02:25
@roomote roomote bot requested review from cte and jr as code owners October 13, 2025 02:25
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Oct 13, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

MCP settings changes in second Roo tab do not persist (multi-tab state sync bug)

2 participants