Enable more native tools by default #9883
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Contributor
Review completed. The new commit adds the required Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
Collaborator
Author
|
@roomote can you fix the failing tests? |
Contributor
Fixed the reported issues. All local checks passed. |
The addition of defaultToolProtocol: "native" to model definitions now triggers the buildNativeToolsArray code path which requires provider.getMcpHub() to be defined. Added the missing mock method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Enable native tools by default for all models in
anthropic.ts,gemini.ts, andopenai.ts, and update a mock function inTask.spec.ts.defaultToolProtocolto"native"for all models inanthropic.ts,gemini.ts, andopenai.ts.getMcpHubmock function inTask.spec.tsto returnundefined.This description was created by
for 30363b0. You can customize this summary. It will automatically update as commits are pushed.