Skip to content

Conversation

@KagurazakaNyaa
Copy link

@KagurazakaNyaa KagurazakaNyaa commented Dec 6, 2025

Related GitHub Issue

Closes: #5733 #5517
Improved: #5778

Roo Code Task Context (Optional)

Description

This PR modifies the approach in #5778 that simply increased the Ollam timeout, allowing users to modify the timeout setting in the embedded settings interface.

Test Procedure

The test was initiated by launching debug mode with F5 and opening a codebase in the debug VS Code instance to begin indexing. A low timeout was set initially, and if errors like those in #5733 occurred, the timeout was increased until the embedding could be completed successfully.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

图片 图片

Documentation Updates

Does this PR necessitate updates to user-facing documentation?

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Both added settings are very intuitive, and the interface elements are sufficient to describe themselves, so there is no need to update the documentation.

Additional Notes

Get in Touch

kagurazakanyaa


Important

Introduces configurable timeout settings for Ollama embedding and validation, with updates to code, tests, UI, and translations.

  • Behavior:
    • Adds configurable timeout settings for Ollama embedding and validation in codebase-index.ts and provider-settings.ts.
    • Updates ClineProvider.ts to handle new timeout settings.
  • Testing:
    • Updates tests in config-manager.spec.ts and ollama.spec.ts to cover new timeout configurations.
  • UI and i18n:
    • Updates CodeIndexPopover.tsx to include new timeout settings fields.
    • Adds translations for new settings in multiple settings.json files.

This description was created by Ellipsis for ebb28f5. You can customize this summary. It will automatically update as commits are pushed.

i18n: Add Ollama timeout configuration localization for all languages (by AI)
Copilot AI review requested due to automatic review settings December 6, 2025 07:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Dec 6, 2025
@roomote
Copy link
Contributor

roomote bot commented Dec 6, 2025

Rooviewer Clock   See task on Roo Cloud

All issues have been resolved.

Issues resolved:

  • Use ?? instead of || for timeout default values in ollama.ts to properly handle 0 as a valid timeout value
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Dec 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configurable timeout settings for Ollama embedding and validation requests, allowing users to adjust these values through the UI instead of relying on hardcoded defaults. This addresses issues where users experienced timeouts during embedding operations on slower systems or with large models.

Key Changes:

  • Added two new configurable settings: ollamaEmbeddingTimeoutMs and ollamaValidationTimeoutMs with defaults of 60000ms and 30000ms respectively
  • Implemented UI controls in the code index popover for users to configure these timeout values
  • Added comprehensive i18n support across 18 locale files

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
src/services/code-index/embedders/ollama.ts Core implementation of configurable timeout logic in the Ollama embedder
src/services/code-index/config-manager.ts Added timeout configuration handling and change detection
packages/types/src/provider-settings.ts Added schema definitions for Ollama timeout settings
packages/types/src/codebase-index.ts Added schema definitions for codebase index timeout settings
src/core/webview/ClineProvider.ts Added timeout settings to webview state management
src/core/webview/webviewMessageHandler.ts Added timeout settings to settings update handler
src/shared/WebviewMessage.ts Added timeout fields to webview message interface
webview-ui/src/components/chat/CodeIndexPopover.tsx Added UI controls for configuring timeout values
webview-ui/src/i18n/locales/*/settings.json Added translations for timeout settings across 18 locales
src/services/code-index/embedders/__tests__/ollama.spec.ts Added tests for timeout configuration
src/services/code-index/__tests__/config-manager.spec.ts Updated tests to include timeout settings
src/services/code-index/__tests__/service-factory.spec.ts Updated tests to include timeout settings
src/services/code-index/interfaces/config.ts Added timeout fields to config snapshot interface

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Timeout configuration too aggressive when using Ollama for codebase index embedding

2 participants