Skip to content

fix: old version process error #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MikuniDOMI wants to merge 2 commits into from
Closed

fix: old version process error #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6509be
fix: old version process error
MikuniDOMI Jan 2, 2026
a8bad47
Delete release-build.yml
MikuniDOMI Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions .github/workflows/release-build.yml
View file
Open in desktop

This file was deleted.

2 changes: 2 additions & 0 deletions BedrockLauncher.Core/BedrockCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,8 @@ public async Task<Process> LaunchGameAsync(LaunchOptions options)

}
Process[] processes = Process.GetProcessesByName("Minecraft.Windows");
Process[] process_oldVersion = Process.GetProcessesByName("Minecraft.Win10.DX11");
processes = processes.Concat(process_oldVersion).ToArray();
process = processes.OrderBy(p => p.StartTime).Last();
}
return process;
Expand Down
2 changes: 1 addition & 1 deletion BedrockLauncher.Core/BedrockLauncher.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Release'">
<Version>2.0.0</Version>
<Version>2.0.0-fix.1</Version>
</PropertyGroup>

<PropertyGroup>
Expand Down
14 changes: 11 additions & 3 deletions CoreTest/InstallTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,19 @@ public void Test()
}))),
Type = MinecraftBuildTypeVersion.UWP,
GameTypeVersion = MinecraftGameTypeVersion.Release,
InstallDstFolder = Path.GetFullPath("./Test5"),
InstallDstFolder = Path.GetFullPath("./Test7"),
GameName = "8899",
FileFullPath = @"D:\Windows11\Download\Microsoft.MinecraftUWP_1.19.8301.0_x64__8wekyb3d8bbwe.Appx"
FileFullPath = @"D:\Windows11\Download\Microsoft.MinecraftUWP_0.140.1.0_x64__8wekyb3d8bbwe.Appx"
};
bedrockCore.InstallPackageAsync(localGamePackageOptions).Wait();
//bedrockCore.InstallPackageAsync(localGamePackageOptions).Wait();
var launchOptions = new LaunchOptions()
{
GameFolder = Path.GetFullPath("./Test7"),
GameType = MinecraftGameTypeVersion.Release,
MinecraftBuildType = MinecraftBuildTypeVersion.UWP,
};
var process = bedrockCore.LaunchGameAsync(launchOptions).Result;
Assert.IsNotNull(process);
}
}
}
2 changes: 1 addition & 1 deletion CoreTest/UriGetTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public async Task TestAsync()
BuildInfo build = null;
await foreach (var kvp in buildDatabaseAsync.Builds)
{
if (kvp.Key == "1.21.131")
if (kvp.Key == "0.14.0")
build = kvp.Value;
}
var result = bedrockCore.GetPackageUri(build,Architecture.X64).Result;
Expand Down