RFC: harden systemd service with safe defaults #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds hardening to the systemd service with a variety of knobs designed to restrict damage that rsync can do as root, while making sure that no file transfers are interrupted. For example, ProtectHome= is still off, and CapabilityBoundingSet is still unlimited to allow for chown/chmod to work unimpeded. The [email protected] has some additional options to restrict all network access and only use the socket on stdin. An equivalent change was done in rsync.service to only allow TCP, but full network isolation is not possible for that unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for an overview, but this is an RFC, I can understand if the project does not want this. The goal here is defense in depth. If there is a bug in any access control or authentication mechanism in rsync, there should be additional protections to not compromise a system running
rsync --daemonas root. This can be accomplished through systemd, so that the damage done by a hypothetical RCE is minimized as much as possible.I have personally tested this and it does not affect file transfers for either unit. That being said, I understand a lot of the options may be confusing. I can explain why each one of these is a safe default that does not affect file transfers.