Skip to content

Prevent inheritance of Admin stats across sessions #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rukafuu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent inheritance of Admin stats across sessions #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 37 additions & 8 deletions Chat/contexts/GamificationContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ export const GamificationProvider: React.FC<{ children: React.ReactNode }> = ({
const mapped = mapBackendToFrontend(data);
if (mapped.level >= 50) isAlreadyAdmin = true;

setStats(mapped);
setStats(mapped);

// Only update/insert self in leaderboard if NOT admin
Expand Down Expand Up @@ -301,7 +300,18 @@ export const GamificationProvider: React.FC<{ children: React.ReactNode }> = ({
const localLevel = ls?.level || 1;
const isSuspiciousData = localLevel >= 10 || (ls?.coins || 0) > 5000;

if (serverIsDefault && (ls || lq || lt || lp || ap) && !isSuspiciousData) {
const clearLocalGamification = () => {
localStorage.removeItem('lira_stats');
localStorage.removeItem('lira_quests');
localStorage.removeItem('lira_unlocked_themes');
localStorage.removeItem('lira_unlocked_personas');
localStorage.removeItem('lira_active_persona');
};

if (isSuspiciousData) {
console.warn('[Gamification] Suspicious local data detected. Clearing.');
clearLocalGamification();
} else if (serverIsDefault && (ls || lq || lt || lp || ap)) {
await fetch(`${backendUrl}/api/recovery/import`, {
method: 'POST',
headers: { 'Content-Type': 'application/json', ...getAuthHeaders() },
Expand All @@ -326,6 +336,10 @@ export const GamificationProvider: React.FC<{ children: React.ReactNode }> = ({
if (Array.isArray(data2?.unlockedPersonas)) setUnlockedPersonas(data2.unlockedPersonas);
if (data2?.activePersonaId) setActivePersonaId(data2.activePersonaId as PersonaId);
}
clearLocalGamification();
} else if (!serverIsDefault) {
// If server has data, local is redundant or from another session
clearLocalGamification();
}
} catch { } // End recovery try
} // End if (r.ok)
Expand Down Expand Up @@ -369,12 +383,27 @@ export const GamificationProvider: React.FC<{ children: React.ReactNode }> = ({
const savedStats = localStorage.getItem('lira_stats');
if (savedStats) {
const parsed = JSON.parse(savedStats);
setStats(parsed);
setLeaderboard(prev => prev.map(u =>
u.isCurrentUser
? { ...u, xp: parsed.currentXp, username: parsed.username }
: u
).sort((a, b) => b.xp - a.xp).map((u, i) => ({ ...u, rank: i + 1 })));

// SECURITY FIX: Prevent guest inheritance of Admin/High-level stats
const localLevel = parsed?.level || 1;
const isSuspiciousData = localLevel >= 10 || (parsed?.coins || 0) > 5000;

if (isSuspiciousData) {
console.warn('[Gamification] Suspicious guest data detected. Clearing.');
localStorage.removeItem('lira_stats');
localStorage.removeItem('lira_quests');
localStorage.removeItem('lira_unlocked_themes');
localStorage.removeItem('lira_unlocked_personas');
localStorage.removeItem('lira_active_persona');
setStats(INITIAL_STATS);
} else {
setStats(parsed);
setLeaderboard(prev => prev.map(u =>
u.isCurrentUser
? { ...u, xp: parsed.currentXp, username: parsed.username }
: u
).sort((a, b) => b.xp - a.xp).map((u, i) => ({ ...u, rank: i + 1 })));
}
}
const savedQuests = localStorage.getItem('lira_quests');
if (savedQuests) setQuests(JSON.parse(savedQuests));
Expand Down
8 changes: 8 additions & 0 deletions Chat/services/userService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,14 @@ export const logout = async () => {
} finally {
localStorage.removeItem(SESSION_KEY);
localStorage.removeItem(CURRENT_USER_KEY);

// Clear gamification stats
localStorage.removeItem('lira_stats');
localStorage.removeItem('lira_quests');
localStorage.removeItem('lira_unlocked_themes');
localStorage.removeItem('lira_unlocked_personas');
localStorage.removeItem('lira_active_persona');

// Optional: Reload page or redirect
window.location.href = '/login';
}
Expand Down