Use X macros to generate DefaultASTVisitor
#3995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like https://clang.llvm.org/docs/ClangFormatStyleOptions.html#macros would be useful, whenever we bump clang-format to version 17 |
powerboat9
force-pushed
the
x-mac-2
branch
4 times, most recently
from
4188adf to
a700bfe
Compare
This should help us reduce mismatches between DefaultASTVisitor and ExpandVisitor later. clang-format is disabled for "ast/rust-ast-visitable-inner.h", as it doesn't seem to handle the macro shenanagins used very well. gcc/rust/ChangeLog: * ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Remove explicit definitions, use X macros. * ast/rust-ast-visitable-inner.h: New file. Signed-off-by: Owen Avery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit messy, but basing default AST visitation on a descriptive DSL is probably one of our best options for regularizing AST visitors.
clang-formatis disabled inast/rust-ast-visitable-inner.h, since I'm not sure how to get it to handle the DSL well.