-
Notifications
You must be signed in to change notification settings - Fork 58
Split compiletests and difftests into parallel CI jobs #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
End-to-end CI Times:
|
I'd only make them depend on each other if we run out of ci runtime tokens, but they're free for open source projects so... who cares. I've added two more things:
|
baseline: ~22 min Most of our CI is now below 10min, apart from the main test. The slowest component is the Also it doesn't have "use-installed-tools"! We also need to exclude our new difftests, as they too depend on wgpu. I moved their testing to our difftest ci and readded the examples exclusion.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm giving you the 👍 but disabled auto-merging so you can have another look at my changes
I'm fine with the changes, though I think it is cleaner to split by "type" (unit, diff, compile) rather than by crate (e.g. the difftest job running difftest and their associated unit tests). But this isn't too complicated yet so it doesn't really matter either way. |
We could have them kick off after the main job and reuse artifacts, but it seems better to just kick them all off at once?