Skip to content

ci: simplify clippy #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ci: simplify clippy #331

wants to merge 2 commits into from
+13 −56

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jul 11, 2025 •
edited
Loading

Requires Rust-GPU/spirv-tools-rs#16 and publishing spirv-tools 0.12.1

Hmpf, unfortunate that we can't pass the features somehow, to a single cargo clippy --workspace invocation.

Alternatively, it might be nice to not have SPIRV-Tools' C++ code be compiled by spirv-tools-rs when built for cargo check/cargo clippy, but I don't recall if that's even feasible to do.

#329 (review)

Well, now we can :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb Awaiting requested review from eddyb eddyb will be requested when the pull request is marked ready for review eddyb is a code owner

@LegNeato LegNeato Awaiting requested review from LegNeato LegNeato will be requested when the pull request is marked ready for review LegNeato is a code owner

@schell schell Awaiting requested review from schell schell will be requested when the pull request is marked ready for review schell is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Firestar99