[dev/syn2] Allow other attributes in #[pin_data] structs #94
+66
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way any future modification into what attributes should be kept can be made in one place rather than chasing all the places where attributes are being filtered. Signed-off-by: Martin Kletzander <[email protected]>
This allows the usage of dummy attributes in tests. Signed-off-by: Martin Kletzander <[email protected]>
Instead of keeping all the member attributes, which might not even make sense for anything else than struct members, keep only those that we're either interested in or might alter the behaviour of the code. This is tested with a new test which illustrates the pre-existing issue where struct might use various attributes for its members which can be valid, but would (before this patch) fail to compile. Signed-off-by: Martin Kletzander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #93 which fixes compilation with unknown/external attributes in the legacy branch, this is a similar approach but for the implementation using
syncrate as requested by @BennoLossin in #93 .I am slightly unsure about few things:
#[cfg]attribute since it might be filtered out before the macro runs?This is also created against the
dev/syn2branch so that it applies there or after #89 . Don't hesitate to let me know if I missed anything anywhere (highly likely). Thanks