fix: replaced empty tuple error types with Infallible #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Sep 5, 2024
|
Seems like a breaking change, but we'll likely need breaking changes to address #53 as well |
|
Yes please! This would be great. Any news on getting this merged? |
|
Looks like you'll need to update how the errors are handled in |
|
If you rebase it should now run the full |
tarcieri
approved these changes
Oct 19, 2024
tarcieri
added a commit
that referenced
this pull request
Oct 21, 2024
There were breaking changes in #59. This denotes that a breaking change occurred, however there won't be a release associated with this commit. Instead we'll release a `pre.0` or a v0.3.0 final.
tarcieri
added a commit
that referenced
this pull request
Oct 21, 2024
There were breaking changes in #59. This denotes that a breaking change occurred, however there won't be a release associated with this commit. Instead we'll release a `pre.0` or a v0.3.0 final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.