fix: anti-recursion guard, stderr capture, review ordering (#272 #273 #274)#275
Open
RyderFreeman4Logos wants to merge 4 commits intomainfrom
Open
fix: anti-recursion guard, stderr capture, review ordering (#272 #273 #274)#275RyderFreeman4Logos wants to merge 4 commits intomainfrom
RyderFreeman4Logos wants to merge 4 commits intomainfrom
Conversation
When claude-code-acp is used as the review/debate tool, it reads CLAUDE.md/AGENTS.md rules containing "MUST use csa review" directives, causing it to invoke csa commands inside Bash — creating an infinite recursion loop that ends in SIGTERM (exit 143). Fix: prepend an explicit anti-recursion instruction to the prompt telling the tool it is running inside a CSA subprocess and must NOT invoke any csa commands. This matches the role detection pattern already documented in the csa-review and debate SKILL.md files. Closes #272 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When an ACP subprocess crashes before initialization, the ProcessExited error only reported the exit code with zero context. The stderr pipe contents (containing crash details like Node.js EPIPE stack traces) were silently lost. Change ProcessExited from a tuple variant to a struct with both code and stderr fields. The ensure_process_running() method now captures the last 10 lines of stderr and includes them in the error message for post-mortem diagnosis. Closes #273 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add condition guard to workflow.toml Step 4 (Push and Create PR) that blocks PR creation when LOCAL_REVIEW_HAS_ISSUES is set. This prevents an orchestrator from creating a PR before the local review passes. Also add explicit precondition documentation to PATTERN.md Step 4 explaining the two-layer review architecture dependency. Closes #274 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues discovered during CSA review workflow execution:
claude-code-acp from invoking
csa run/review/debatewhen running inside CSAProcessExitederror forcrash diagnosis instead of reporting only the exit code
condition = "!(${LOCAL_REVIEW_HAS_ISSUES})"guard to pr-codex-botStep 4 to mechanically enforce review-before-PR ordering
Test plan
csa review --tool claude-codeno longer causes infinite recursioncargo test -p csa-acppasses (44 tests)cargo clippyclean🤖 Generated with Claude Code