fix(pattern): harden dev2merge timeout fallback and workflow sync#294
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1aca3b81b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
patterns/dev2merge/workflow.toml
Outdated
| exit 1 | ||
| echo "INFO: Timed out waiting for cloud bot response after ${TIMEOUT}s; running local fallback review." >&2 | ||
| set +e | ||
| LOCAL_REVIEW_OUTPUT="$(csa review --range main...HEAD --tool auto 2>&1)" |
There was a problem hiding this comment.
--tool auto in fallback review command
This timeout fallback calls csa review --range main...HEAD --tool auto, but csa review parses --tool as ToolName (valid values are explicit tools like codex, claude-code, gemini-cli, opencode), so auto is rejected at CLI parse time and the fallback never runs. In the cloud-timeout path this causes the script to hit the Local fallback review failed unexpectedly branch and abort instead of recovering, which defeats the main reliability change; the same issue appears in the re-trigger fallback and in the mirrored dev-to-merge workflow.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6a3d54d06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| title = "Include mktd" | ||
| tool = "weave" | ||
| prompt = "mktd" | ||
| prompt = ''' |
There was a problem hiding this comment.
The Include mktd step no longer declares tool = "bash", so csa plan resolves it through the default CSA-tool path (see resolve_step_tool fallback) instead of executing the fenced script directly. In that mode the prompt is treated as model input with ${...} substitution, so the intended deterministic gate (csa run --skill mktd plus TODO file validation and MKTD_TODO_* output) may be skipped or mangled, which can let the workflow continue without actually enforcing the required mktd plan checks (the same omission is mirrored in patterns/dev-to-merge/workflow.toml).
Useful? React with 👍 / 👎.
1 participant
Summary
Validation