fix(run): improve recovery path for SIGTERM/SIGINT interruptions#303
fix(run): improve recovery path for SIGTERM/SIGINT interruptions#303RyderFreeman4Logos merged 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b66386dab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cleanup_pre_created_fork_session( | ||
| &mut pre_created_fork_session_id, | ||
| &project_root, | ||
| ); |
There was a problem hiding this comment.
This interruption branch deletes pre_created_fork_session_id before returning the resume guidance, but native fork runs use that pre-created ID as the active session (effective_session_arg) and execute_transport_with_signal persists interruption state into it. In a SIGINT/SIGTERM during a native fork, the code can print a --session <id> hint for the same ID it just deleted, so resume immediately fails because the referenced session no longer exists.
Useful? React with 👍 / 👎.
| if message.contains("sigterm") { | ||
| return Some(143); | ||
| } | ||
| if message.contains("sigint") { | ||
| return Some(130); |
There was a problem hiding this comment.
The new classifier treats any error-chain message containing sigterm/sigint as an interruption, which can misclassify non-interruption failures (for example, signal-handler setup errors like Failed to register SIGINT handler from execute_transport_with_signal) as exit 130/143. In that case users get an "interrupted" response and fallback/error handling is skipped even though no OS signal interrupted execution.
Useful? React with 👍 / 👎.
1 participant
Summary
meta_session_idcontext to pipeline transport errors after session creationcsa run(exit 143/130), instead of generic fatal errors or fallback retries--skillworkflows can be resumed with the exact session idVerification
Fixes #302