feat(csa): add pre-review quality gate, project hooks, and configurable timeout#383
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
…le timeout Add a pre-review quality gate that runs `just pre-commit` before review/debate sessions to catch issues early. Introduce project-level hooks configuration in .csa/config.toml with pre_review, post_review, and pre_commit hook support. Key changes: - pipeline_gate: new module implementing quality gate with configurable retries, pass-through mode, and structured error reporting - review_cmd_resolve: extract review argument resolution into dedicated module, reducing review_cmd.rs from god-object to focused orchestrator - config: add ProjectHooksConfig and ReviewConfig.timeout field with global/project merge support and is_default() for serde-default safety - debate_cmd: integrate quality gate with debate workflow - Comprehensive test coverage (334 lines of gate tests, 452 lines of merge tests) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just pre-commitbefore review/debate sessions to catch lint/test failures early, with configurable retry count and pass-through mode[hooks]section in.csa/config.tomlsupportingpre_review,post_review, andpre_commithooks with global/project mergeReviewConfig.timeoutfield with properis_default()guard for serde-default safety (rule 016)review_cmd_resolve.rs, reducingreview_cmd.rsfrom monolith to focused orchestratorKey Files Changed
New modules
crates/cli-sub-agent/src/pipeline_gate.rs— Quality gate implementation (245 lines)crates/cli-sub-agent/src/pipeline_gate_tests.rs— Gate unit tests (334 lines)crates/cli-sub-agent/src/review_cmd_resolve.rs— Review arg resolution (377 lines)crates/csa-config/src/config_merge_tests_tail.rs— Config merge tests (260 lines)Modified (key changes)
crates/csa-config/src/config.rs—ProjectHooksConfig,ReviewConfig.timeout,is_default()methodscrates/csa-config/src/global.rs— Global hooks supportcrates/csa-config/src/config_merge.rs— Hooks merge logiccrates/cli-sub-agent/src/review_cmd.rs— Slimmed down, delegates to resolve modulecrates/cli-sub-agent/src/debate_cmd.rs— Quality gate integrationcrates/csa-scheduler/src/failover.rs— Hook-aware failovercrates/csa-scheduler/src/rotation.rs— Hook-aware rotationStats
Test Results
Closes #378
🤖 Generated with Claude Code