fix(pipeline): robust contract violation parsing for verbose agent output#384
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Mar 8, 2026
Merged
Conversation
…tput Add disk-based result.toml fallback and embedded path extraction to handle cases where employee tools produce verbose multi-line output that prevents clean path extraction from stdout. Two-pronged fix: - session_result_fallback_is_valid() validates session-dir result.toml on disk when output parsing fails (symlink + nlink + TOML checks) - extract_embedded_result_toml_path() scans output lines for absolute paths ending in result.toml even when surrounded by other text Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
result.tomlfallback when stdout path extraction fails (validates file exists, not symlink, nlink==1, valid non-empty TOML)extract_embedded_result_toml_path) to find result.toml paths within longer output linesFixes the "contract violation" false positive when CSA employee tools produce verbose multi-line output that buries the result.toml path.
Test plan
just pre-commitpasses (2443 unit + 16 e2e tests)result_toml_path_contract_extracts_embedded_path,result_toml_path_contract_accepts_verified_session_result_fallback,result_toml_path_contract_handles_verbose_multiline_output🤖 Generated with Claude Code