feat(config): add model field to ReviewConfig and DebateConfig#386
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Mar 9, 2026
Merged
feat(config): add model field to ReviewConfig and DebateConfig#386RyderFreeman4Logos merged 1 commit intomainfrom
RyderFreeman4Logos merged 1 commit intomainfrom
Conversation
Review and debate workflows were not passing --model to gemini-cli, causing model steering to select Flash instead of Pro. Root cause: apply_tool_defaults=false (by design) blocks [tools.gemini-cli].default_model, and ReviewConfig/DebateConfig had no model field of their own. Changes: - Add model: Option<String> to ReviewConfig and DebateConfig - Add Executor::override_model() for explicit model > tier model_spec - Wire model resolution in review_cmd.rs and debate_cmd.rs (CLI --model > config model > tier model_spec > tool default) - Update build_executor to apply model override when model_spec present - Split global_tests.rs to stay under 800-line limit - Add 9 new tests (config parsing, is_default, serialization, override) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
Merge rationale: Cloud bot (@codex) is disabled or unavailable. Local |
|
To use Codex here, create an environment for this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modelfield toReviewConfigandDebateConfig(both global and project-level) so review/debate workflows can pin a specific model (e.g.gemini-3.1-pro-preview) independent of tier or tool defaults--model> config[review/debate].model> tiermodel_spec> tool defaultExecutor::override_model()method parallel to existingoverride_thinking_budget()for explicit model steeringglobal_tests.rsintoglobal_tests.rs+global_tests_heterogeneous.rsto stay under 800-line module limitMotivation
When
apply_tool_defaults = false(intentional for review/debate), tool-leveldefault_modelis bypassed. Combined with gemini-cli 0.32+modelSteering: true, this caused gemini-cli to silently select Flash instead of Pro for critical review/debate tasks. The newmodelfield provides a direct, unambiguous way to pin models at the workflow level.Test plan
just test)just pre-commitpasses (fmt, clippy, test, monolith check)test_parse_review_config_with_model,test_review_config_model_none_is_default,test_review_config_model_skipped_when_none,test_parse_debate_config_with_model,test_debate_config_model_none_is_defaultcsa review --range main...HEAD) passed cleanmodel: Nonedefault, existing configs parse unchanged🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com