fix(patterns): add early-push detection to pr-codex-bot#390
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Mar 10, 2026
Merged
fix(patterns): add early-push detection to pr-codex-bot#390RyderFreeman4Logos merged 1 commit intomainfrom
RyderFreeman4Logos merged 1 commit intomainfrom
Conversation
…ot (#387) Add defensive guard to pr-codex-bot Step 4 that detects when the feature branch was already pushed to remote before the skill ran, and warns that unreviewed code may have been exposed. Changed push from plain `git push` to `git push --force-with-lease` so the reviewed code always reaches the remote. Also added explicit FORBIDDEN note in SKILL.md prerequisites: pushing before invoking the skill violates the review-before-push ordering. Closes #387 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--force-with-leaseto ensure reviewed code overwrites any pre-pushed unreviewed codeContext
The pr-codex-bot pattern enforces review-before-push via a
REVIEW_COMPLETEDprecondition gate in Step 4. However, the orchestrator could push the branch before invoking the skill, bypassing this ordering. This fix adds runtime detection and documentation.Test plan
weave compilepasses for modified patternCloses #387
🤖 Generated with Claude Code