fix(transport): prohibit flash model fallback in review/debate#394
Merged
RyderFreeman4Logos merged 1 commit intomainfrom Mar 10, 2026
Merged
fix(transport): prohibit flash model fallback in review/debate#394RyderFreeman4Logos merged 1 commit intomainfrom
RyderFreeman4Logos merged 1 commit intomainfrom
Conversation
Review and debate require high-quality reasoning models. The transport retry loop previously could degrade from pro to flash on quota errors, which is unacceptable for these quality-critical paths. - Add _CSA_NO_FLASH_FALLBACK env signal, respected by retry logic - When set, max retry attempts reduced from 3 to 2 (skips flash) - Inject signal in review_cmd.rs and debate_cmd.rs extra_env - Also inject _CSA_API_KEY_FALLBACK in review/debate (was missing) - Add test verifying no-flash stops retry at attempt 2
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
Merge RationaleCloud bot: disabled ( Local review coverage:
Test results: 2466 unit + 16 e2e tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_CSA_NO_FLASH_FALLBACKenv signal: when set, retry stops after pro model (skips flash)review_cmd.rsanddebate_cmd.rs_CSA_API_KEY_FALLBACKfor review/debate (was missing from PR feat(transport): automatic API key fallback for gemini-cli quota exhaustion #393)Retry behavior
csa run(default)csa review/csa debateTest plan
test_no_flash_fallback_stops_retry_after_attempt_2just pre-commitclean