Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to add selected rows to export #104

Merged
merged 18 commits into from
Nov 6, 2024

Conversation

milanmlft
Copy link
Member

@milanmlft milanmlft commented Oct 30, 2024

Closes #93
Also closes #94, as it will be no longer relevant.

To do

  • Update user manual

Now, unselecting a row and then pressing the 'update selection' button
doesn't remove the unselected rows from the export selection.
…ctor

This avoids some sneaky bugs with the previous `full_join` approach
where data might get duplicated when changing the date filter
@milanmlft milanmlft requested a review from a team October 30, 2024 20:01
@milanmlft
Copy link
Member Author

Do we want a clear selection button to reset the export selection?

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (40c345a) to head (ca3cf83).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   96.99%   97.02%   +0.02%     
==========================================
  Files          19       19              
  Lines         566      571       +5     
==========================================
+ Hits          549      554       +5     
  Misses         17       17              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as you have there, need to update user manual.

@milanmlft milanmlft enabled auto-merge (squash) November 6, 2024 15:49
@milanmlft milanmlft merged commit dd9f180 into main Nov 6, 2024
3 checks passed
@milanmlft milanmlft deleted the milanmlft/93-94-improve-export-selection branch November 6, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants