Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCP1]Remove "Software Component" related fields #576

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

goreraks
Copy link
Contributor

Initially we decided to keep "Software Component", "Minimum Release" and "Maximum Release" fields that can be maintained for BC Sets. Because of Software Components are being merged, the code split from S/4 and the issues raised while activating a BC Sets in Steampunk environment, we decided not to keep these fields in AFF.

@wurzka had requested to upload a simple example with lesser in file size. So I will create a seperate PR for the same soon.

@goreraks goreraks changed the title Remove "Software Component" related fields [SCP1]Remove "Software Component" related fields Dec 18, 2023
@albertmink
Copy link
Contributor

This thing with the example is, the example is no longer valid with the changes in the JSON Schema. As a workaround, you could remove the data in the existing example, softwareComponent, minimumRelease and maximumRelease. Or you add the simplified example to this PR.

@schneidermic0
Copy link
Contributor

wurzka had requested to upload a simple example with lesser in file size. So I will create a separate PR for the same soon.

I agree with Albert. We should also update the example so that it is at least is compatible with your changes.

@schneidermic0
Copy link
Contributor

schneidermic0 commented Dec 18, 2023

Technically, your changes are incompatible. As far as I know SCP1 file format is not available, is it?

@goreraks
Copy link
Contributor Author

Yes, SCP1 file format is not yet available.

@schneidermic0
Copy link
Contributor

@goreraks There hasn't been any update to this PR for 6 weeks now. When do you plan to fix the example? Without fixing the example we cannot merge this PR in our main branch because we will see failing tests.

@schneidermic0 schneidermic0 marked this pull request as draft February 23, 2024 14:29
@schneidermic0
Copy link
Contributor

No update since more than two months. I have converted this to "draft"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants