[EDCC] Add new object type for EDCC #661
Conversation
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "AFF type for EDCK", |
There was a problem hiding this comment.
| "description": "AFF type for EDCK", | |
| "description": "AFF type for EDCC", |
What does EDCC stand for?
| message_type_description TYPE ty_short_description, | ||
| "! <p class="shorttext">Tax Authority Document Type</p> | ||
| "! Tax authority document type | ||
| taxauth_documenttype TYPE c LENGTH 20, |
There was a problem hiding this comment.
tax_authority_document_type
| original_language TYPE zif_aff_types_v1=>ty_original_language, | ||
| END OF ty_message, | ||
| "! <p class="shorttext">Tax Authority Message Types</p> | ||
| "! Tax Authority Message types |
There was a problem hiding this comment.
| "! Tax Authority Message types | |
| "! Tax authority message types |
Sentence case
|
@GuilhermeSaraiva96 : I have incorporated the above suggested changes. Please have a look and suggest if we can have a meeting to understand this AFF. |
|
@GuilhermeSaraiva96 : Let us know if the AFF requires further adjustment |
|
Hi, thank you for your changes, looks good already. I have just a few more suggestions. Additionally, could you please send a meeting request so that we can discuss the whole AFF before moving to the UX review? Thanks! |
|
@GuilhermeSaraiva96 : I have regenerated the examples and incorporated changes related to description of objects coming from other object types like EDCR/EDCK. Additionally I have added one new node in the AFF in ty_main, additional_selection_fields. Please have a look and let me know. |
|
From my side, it is ready for the UX-Review. @nicolas? |
|
@GuilhermeSaraiva96 : Above comments are fixed. please have a look |
|
ready for UX Review |
GuilhermeSaraiva96
added
ux-review ready
| "! <p class="shorttext">Country</p> | ||
| "! Country | ||
| "! $required | ||
| country TYPE c LENGTH 3, |
There was a problem hiding this comment.
Can you please put the country field into a structure general_information
No description provided.