Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTM] Add new object type INTM #671

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion file-formats/intm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`sapj97myt5r25l0v2ijp2rt1pko4.intm.json`](./examples/sapj97myt5r25l0v2ijp2rt1pko4.intm.json)
`<name>.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`z_aff_example_intm.intm.json`](./examples/z_aff_example_intm.intm.json)
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"originalLanguage": "en"
},
"generalInformation": {
"modelName": "RM_TEST_ADT_976_MOD",
"modelName": "RM_TEST_ADT_974_MOD",
"modelType": "SAPGENAI",
"intelligentScenario": "RM_TEST_ADT_976",
"modellingContextId": "7FD071C0C04C56148FE3424E30FFB40B",
"intelligentScenario": "RM_TEST_ADT_974",
"modellingContextId": "685A28A5E8E8 Default context",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended the context ID contains spaces?

"adapterId": "SAPGENAI.Default",
"nativeModelType": "SAPGENAI.Default",
"state": "Published",
Expand All @@ -21,14 +21,12 @@
"promptTemplateName": "SYSTEM_PROMPT",
"promptTemplateDescription": "System prompt",
"prompt": "You are a sales executive who is responsible for reaching out to customers for confirming or declining their orders. Evaluate the size of the delivery vehicle based on the number of items. Calculate the distance between the billing and delivery location in kilometers. \r\n\r\nThe subject of email should be of format <Confirmation on order number: {order_number} placed on {booking_date}> \r\nThe body of email should be of format: \"\"SO contains <Category> to be delivered to <Location>. And will be delivered via a <size> vehicle. \r\nIF <distance between source address and delivery address> > 100 kms THEN include a message about potential delivery delays ELSE congratulate on being eligible for one day delivery",
"promptParameters": "[]",
"isVisible": true
},
{
"promptTemplateName": "USER_PROMPT",
"promptTemplateDescription": "User prompt",
"prompt": "Build a confirmation mail for a sales order containing {ISLM_Items} where the items are categorized for example pencil and paper will be stationary, printer and mouse will be electronics. The source address contains {ISLM_Source} and the delivery address is in {ISLM_Destination}.",
"promptParameters": "[{\"Name\":\"ISLM_Items\",\"Value\":\"\"},{\"Name\":\"ISLM_Source\",\"Value\":\"\"},{\"Name\":\"ISLM_Destination\",\"Value\":\"\"}]",
"isVisible": true
}
]
Expand Down
5 changes: 0 additions & 5 deletions file-formats/intm/intm-v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,6 @@
"description": "Prompt",
"type": "string"
},
"promptParameters": {
"title": "Prompt Parameters",
"description": "Prompt parameters",
"type": "string"
},
"isVisible": {
"title": "Prompt Visibility",
"description": "If true, the prompt is visible",
Expand Down
3 changes: 0 additions & 3 deletions file-formats/intm/type/zif_aff_intm_v1.intf.abap
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ INTERFACE zif_aff_intm_v1
"! Prompt
"! $required
prompt TYPE string,
"! <p class="shorttext">Prompt Parameters</p>
"! Prompt parameters
prompt_parameters TYPE string,
"! <p class="shorttext">Prompt Visibility</p>
"! If true, the prompt is visible
is_visible TYPE abap_bool,
Expand Down
2 changes: 1 addition & 1 deletion file-formats/intm/type/zif_aff_intm_v1.intf.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"formatVersion": "1",
"header": {
"description": "Intelligent Scenario Model (INTM)",
"description": "General types reusable in AFF",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the description of the AFF itself, so what does this AFF do? What does INTM stand for? Intelligent Model?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not part of our interface.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change it either way. This is the description of the AFF itself. Same for the other INTS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is a regression ^^ :)

"originalLanguage": "en"
}
}
Loading