[EDOT] Add new object EDOT #682
Conversation
There was a problem hiding this comment.
Thanks for your pull request. This pull request still contains both, EDOI and EDOT (with the .DS_Store). Please remove all the unwanted files here.
Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.
"! <p class="shorttext">Interface Version</p> "<- title (title case)
"! Interface version "<- description (sentence case)
file-formats/edot/.DS_Store
Outdated
There was a problem hiding this comment.
This file should be deleted
There was a problem hiding this comment.
somehow i coudn't see this hidden file but anyhow i replaced whole folder
There was a problem hiding this comment.
The file is there again, which is strange as it is excluded in our .gitignore. Assuming you are on macOS, can you please try the steps described here on your feature branch? https://www.geeksforgeeks.org/how-to-remove-ds_store-files-from-git-repositories/
There was a problem hiding this comment.
thank you for the link, I have deleted and push to git. please check now
file-formats/edot/README.md
Outdated
There was a problem hiding this comment.
I think having an example would also help me for the review
There was a problem hiding this comment.
Somehow I am unable to generate example, I created class and Transformation but its not clear to me in the report what object to be mentioned as input.
| "! <p class="shorttext">Additional Selection Fields</p> | ||
| "! Additional selection fields of validation report | ||
| edocument_sral_configuration TYPE ty_sral_configurations, | ||
| "! <p class="shorttext">eDocument Type Specific Additional Tables</p> | ||
| "! eDocument Type Specific Additional Tables | ||
| edoc_spec_additional_table TYPE ty_additional_tables, |
There was a problem hiding this comment.
I am wondering whether it make sense to move these two fields (representing tables/arrays) on top level into ty_main. Maybe, you want to check this also during UX review.
For "general information" it seems to me too detailed.
I corrected and pushed the latest changes, can you please check |
There was a problem hiding this comment.
Thank you for submitting the AFF and changes. Most of my comments are minors and just a personal touch, up to you if you want to implement them :)
However, I always like to mention that AFF is a readable representation of an ABAP Object Type, and the more coherent the field names are, the better!
| contingency_type TYPE c LENGTH 10, | ||
| "! <p class="shorttext">Preprocess Before Archiving</p> | ||
| "! Preprocess before archiving | ||
| archive_prep_req TYPE abap_bool, |
There was a problem hiding this comment.
| archive_prep_req TYPE abap_bool, | |
| archive_preprocess TYPE abap_bool, |
| table_name TYPE zif_aff_types_v1=>ty_object_name_30, | ||
| "! <p class="shorttext">Created in Contingency Mode</p> | ||
| "! Created in contingency mode | ||
| contingency_mode TYPE abap_bool, |
There was a problem hiding this comment.
What is the contingency_mode referring to? to the edoc type or to the table?
Not really familiar with the topic, but it seems like it could belong to the table. Am I correct?
I would also like to understand the relationship between the contingency_mode and the contingency_edoc_type. Could it be that contingency_edoc_type is only relevant when contingency_mode is true?
There was a problem hiding this comment.
Yes, contingency_edoc_type is relevant when contingency mode is activated.
Contingency is a process related to eInvoice solution that introduced by Government authorities (some countries) to process Invoice in offline instead of online submission when Tax authority server is down.
In our UI, user switch the invoice to contingency mode.
There was a problem hiding this comment.
As discussed in the call, contingency_mode and the attribute below are moved to the bottom of the structure
| "! Created in contingency mode | ||
| contingency_mode TYPE abap_bool, | ||
| "! <p class="shorttext">eDocument Type Created Using Contingency</p> | ||
| "! eDocument type created using contingency |
There was a problem hiding this comment.
| "! eDocument type created using contingency | |
| "! Contingency eDocument type |
same for the shortest
No description provided.