Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADVC] Add new object type ADVC #686

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Conversation

SHAFFNER7
Copy link
Contributor

No description provided.

Copy link

cla-assistant bot commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

@huber-nicolas huber-nicolas added the new-object This is a new object type added to AFF label Feb 13, 2025
@schneidermic0
Copy link
Contributor

I have just changed the configuration for line endings of the example file to LF (instead of CRLF).

@SHAFFNER7
Copy link
Contributor Author

Thanks ! How did you do that ?

@schneidermic0
Copy link
Contributor

schneidermic0 commented Feb 14, 2025

How did you do that ?

I used VS Code for this. There, you can change the line endings for a file in the bottom right corner:
image

BTW - You can open VS Code on this PR in your browser by pressing . on your keyboard

@SHAFFNER7
Copy link
Contributor Author

Thanks for the explanation !

@huber-nicolas
Copy link
Contributor

Thanks @SHAFFNER7 for your contribution.
I have talked with @schneidermic0 about the state of ADVC and I am going to help him reviewing this Abap File Formats.

My first question is whether you want to add some more fields to this File Format. Currently it only has the minimum required fields.

@SHAFFNER7
Copy link
Contributor Author

We do not need more fields - we do ADT Editor integration for enablement of deletion of ADVC objects - and for that purpose this information is sufficient

@huber-nicolas huber-nicolas self-assigned this Feb 18, 2025
@huber-nicolas huber-nicolas self-requested a review February 18, 2025 08:09
@huber-nicolas
Copy link
Contributor

@SHAFFNER7 When requesting the ADT Editor please only request a json source based editor (and not the form-based editor)

@huber-nicolas huber-nicolas merged commit e734fbc into SAP:main Feb 26, 2025
10 checks passed
@SHAFFNER7
Copy link
Contributor Author

What is meant by 'When requesting the ADT Editor please only request a json source based editor (and not the form-based editor)' ?
How can I start the ADT Form UI Dev Tool in Eclipse ? When I press CTRL+3 an empty window is displayed - no
ADT Form UI DEV Tool
"Launch ADT Form UI Dev Tool".

@SHAFFNER7 SHAFFNER7 deleted the feature/advc branch February 26, 2025 13:47
@huber-nicolas
Copy link
Contributor

What is meant by 'When requesting the ADT Editor please only request a json source based editor (and not the form-based editor)' ? How can I start the ADT Form UI Dev Tool in Eclipse ? When I press CTRL+3 an empty window is displayed - no ADT Form UI DEV Tool "Launch ADT Form UI Dev Tool".

which ADT version do you have? Can you try to update your ADT?

@SHAFFNER7
Copy link
Contributor Author

ADT version is 3.48.3
I tried an update but that did not help
ADT version

@huber-nicolas
Copy link
Contributor

@SHAFFNER7 I will reach out to you outside of GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants