style: computing a 'sign in' button enablement - #229
Open
alex-gilin wants to merge 1 commit into
Open
Conversation
Contributor
|
I've tried running this change, but it still behaves the same. What should this fix do?
|
alex-gilin
force-pushed
the
signin-enable
branch
from
June 30, 2022 12:23
0a783cb to
8a26a1c
Compare
|
This pull request fixes 1 alert when merging 8a26a1c into 9b593e3 - view on LGTM.com fixed alerts:
|
Contributor
|
Now the sign-in button is also disabled when we don't touch the endpoint
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.